Bjorn Lu

icon indicating a website link https://bjornlu.com icon indicating an email [email protected]

icon location Kuching, Sarawak, Malaysia icon location Building tools for fun. @vitejs core team member.

Results 767 comments of Bjorn Lu

fix: encode URLs correctly (fix #15298)

Moving this to 5.2 since we're releasing 5.1 soon and the PR needs an update to finish up.

fix: encode URLs correctly (fix #15298)

I went ahead and rebased this, and fixed the URI malformed issue. The issue long exists in Vite, only when you reference an asset with `%` in the filename. I...

fix: encode URLs correctly (fix #15298)

/ecosystem-ci run

chore(deps): bump rollup to 4.7.0

Vite doesn't exactly need to bump Rollup though, you can update Rollup in your project yourself with `npm update rollup`, which works recursively and updates what Vite uses too. Though...

chore(deps): bump rollup to 4.7.0

Rollup is now on 4.13.0. Are you able to rebase this to upgrade to 4.13.0 instead?

chore(deps): bump rollup to 4.7.0

Thanks for the quick update! Seems like the windows CI is failing (twice), I can help check it

create vite template react gives typescript errors on jsx files

Did you install the dependencies? I don't see any errors locally.

create vite template react gives typescript errors on jsx files

Just guessing, is there any `tsconfig.json` up the directory from the project? TypeScript can recursively pick a `tsconfig.json` outside of your project too.

fix: check the existence of "document" before using it

Can you explain how and why the `document` is being called in workers? Ideally with a repro? Those places where you edit shouldn't get triggered inside workers, but if we...

fix: check the existence of "document" before using it

https://github.com/vitejs/vite/pull/12988 was a quick fix as we only then discovered that `/@vite/client` snucked into workers code. It shouldn't have been loaded in the first place. https://github.com/vitejs/vite/pull/14918 was a fix that...