vite icon indicating copy to clipboard operation
vite copied to clipboard

chore(deps): bump rollup to 4.7.0

Open moui0 opened this issue 2 years ago • 3 comments

Description

rollup 4.7.0 added riscv64 support: https://github.com/rollup/rollup/pull/5288

Updating rollup makes it possible to build vite on riscv64 linux.

Additional context


What is the purpose of this pull request?

  • [ ] Bug fix
  • [ ] New Feature
  • [ ] Documentation update
  • [x] Other

Before submitting the PR, please make sure you do the following

  • [x] Read the Contributing Guidelines, especially the Pull Request Guidelines.
  • [x] Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • [x] Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • [ ] Update the corresponding documentation if needed.
  • [ ] Ideally, include relevant tests that fail without this PR but pass with it.

moui0 avatar Dec 09 '23 08:12 moui0

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

I noticed that my PR has been pending for a while. I understand you might be busy, but I was wondering if you could spare some time to review my code. If there are any feedback or issues, I am more than happy to address them promptly.

Thank you!

moui0 avatar Dec 25 '23 13:12 moui0

Vite doesn't exactly need to bump Rollup though, you can update Rollup in your project yourself with npm update rollup, which works recursively and updates what Vite uses too.

Though I don't think there's much harm with this PR too, it could be something we update in the next minor.

bluwy avatar Dec 26 '23 04:12 bluwy

Rollup is now on 4.13.0. Are you able to rebase this to upgrade to 4.13.0 instead?

bluwy avatar Mar 12 '24 13:03 bluwy

Thanks for the quick update! Seems like the windows CI is failing (twice), I can help check it

bluwy avatar Mar 12 '24 14:03 bluwy