Bjorn Lu

Results 767 comments of Bjorn Lu

> some environments where specific files 1) need dynamic imports 2) cannot be modules. I don't quite understand this. Dynamic imports only work for modules, if it can't be modules,...

Seems like `dayjs` is seen as commonjs, and there's a related upstream bug: https://github.com/rollup/plugins/issues/1425 Thanks for the simple repro (and sorry for not responding in the other issue). Got a...

@derheld42 that seems to be a SvelteKit specific issue: https://github.com/sveltejs/kit/issues/8948 You can fix it with: ```js const config = { kit: { version: { name: 'test' // something stable instead...

Yup, we usually have weekly dependency updates so the new version should be picked up soon.

I think this make sense for the next minor too. The first case is pretty strange and doesn't fit `optimizeDeps` that I think it's safe to bump this.

Closing this for now as we have a patch on v9, and v10 could be a breaking change for users.

Let's close this one in favour of fixing upstream then. Thanks for starting the work on this!

This is now supported through `ssr.resolve.externalConditions`. We could revisit this again if Node exposes the API.

Ah ok I misread it. I'm not really sure still if there's much we can do without the node api, or we have to rework how we load config files.