Bjorn Lu
Bjorn Lu
This should be fixed in https://github.com/vitejs/vite/pull/15118
`buildEnd` should be called in dev too, it's documented in https://vitejs.dev/guide/api-plugin.html#universal-hooks. Seems like a bug it's not being called now.
I took a look, and it seemed to work in Vite 4 because we took control of Ctrl+C via `setRawMode`, which was part of the breaking change related to the...
I don't see the plugin running when running `npm run build` in the repro 🤔
What would be the suggested solution to distinguish between them? Different package managers can have different ways of linking. Checking `node_modules` is the fastest and often correct.
I think it's unlikely for us to add a new option specifically to detect if a dependency is linked or not. Using `dependenciesMeta.*.injected`, or the `file:` protocol in pnpm, means...
Yeah I'd ignore the CI fails that aren't related to plugin-legacy. It's flaky lately. > If we directly sort the combined polyfills list, this ordering will be broken, and some...
Thanks for investigating this @shankerwangmiao. Seems like `babel-preset-env` might have a bug with the ordering but I can't find out why. From the current implementation, I don't understand why we...
If babel adds another polyfill, wouldn't that still be fine? It shouldn't be having a specific order if it's not core-js, but if it needs a specific order, we can...
Even if babel is correctly outputting in the right order today, there's still the problem where `additionalModernPolyfills` or `additionalLegacyPolyfills` get merged and there are not in the right order. Having...