Bjorn Lu

Results 767 comments of Bjorn Lu

What I had in mind is that, if there's any polyfills that aren't within `core-js-compat/modules.json`, then we keep the ordering as-is. However, it is more complex I think 🤔 For...

Vite doesn't quite support import attributes yet, which is tracked at https://github.com/vitejs/vite/issues/14674. But after that we could may consider re-shaping the API to not rely on query params, so leaving...

Looks like Nuxt fail earlier was a fluke. The others were already failing.

I think in general, we want to hide `import.meta.glob` as an implementation detail of dynamic imports only, so exposing it in the error message could be more confusing? IIUC the...

I think maybe directly appending `Note that variables only represent file names one level deep` should also be fine. It would be nice to optionally show it if we know...

Seems like a bug we didn't anticipate. When Vite sees the `${}` it assumes that the dynamic import has variables and try to transform as: ```js const result = import.meta.glob('./...')...

I haven't looked into the issue much yet, but if accessing `/home` once is really slow, we might need to skip it on MacOS. Otherwise if it's only slow in...

I wonder if the Rollup behaviour is correct though. `__esModule` means that if you default import a module, you'd access `{}.default`. If we have to check whether `.default` exist, then...

When we closed https://github.com/vitejs/vite/issues/12693, we implicitly agreed that the visbilitychange check is enough rather than needing to implement exponential backoff. So I don't think it's unintentional that the issue had...

Do you leave the tab open but still visible? I don't quite understand why the browser would lag after you return to it though. The ping isn't doing anything intensive...