Bjorn Lu
Bjorn Lu
Sorry I've been meaning to take a look and give a suggestion, but haven't got around yet.
> RollupError: "node_modules/typescript/lib/typescript.js" contains dynamic require statements but it is not within the current dynamicRequireRoot "node_modules\typescript\lib". You should set dynamicRequireRoot to "node_modules/typescript/lib" or one of its parent directories. It seems...
The option is handled by the Rollup plugin internally. Maybe you could insert a breakpoint before where the error occurred to see how that value is derived. And how the...
As found in https://github.com/vitejs/vite/pull/11839#issuecomment-1411656243, this would need to be fixed upstream in `@rollup/plugin-dynamic-import-vars`
Not sure if you've gotten consent from the original author of the code to re-package it, but we need confirmation on that before we can accept this. Thanks!
The bug is fixed in es-module-lexer now, but it introduces a regression at https://github.com/guybedford/es-module-lexer/issues/148 so we can't bump it yet.
Cleaning up some stale PRs. Feel free to open a new PR for this once the tests are fixed!
Thanks for keeping the git diff clean for this one. I've been thinking of a cheaper way around this too, and maybe this works: 1. Keep using `resolveFrom`, but append...
Ah you're right 🥲 It looks like we _need_ to always resolve the package then, and using `tryNodeResolve` to ensure it's the same. Let's go with that then.
Sorry I had only had the time to do a full review. The refactor to make this work looks great to me, but it seems like this fails for `vitepress`...