Bjorn Lu

I have not thought about the dev tools case and that makes sense that the memory will rise because of it. I'll re-open this then and we could re-consider the...

/ecosystem-ci run

This seems to be a limitation with the SVG inlining heuristic as we inline SVGs that contain the `'` character. So when you manually add that to `url()` in style...

I looked into the fail. It's failing on this runtime browser error: ``` Error [ReferenceError]: __VUE_PROD_DEVTOOLS__ is not defined at http://localhost:4173/assets/index-395tA5rm.js:5221:1 ``` For some reason the actual build output is...

Thanks 👍 Yeah I think either solutions work for me. If I have to pick one, I'd prefer the `server.hmr.channels` config though. Plugins can use the `config()` hook to add...

If performance is a concern, I did some tests and I found that browsers can generally handle un-encoded imports too. It'll encode them automatically when requesting. Even if the import...

Based on the repro, is your main concern of this inconsistency on this HTML during `vite preview`? ```html ``` The strings come from this source code: ```ts import testLogo from...

I think this PR is doing more than expected to fix the issue for `vite-imagetools` though. We only need to encode the `filename` [as linked before](https://github.com/vitejs/vite/blob/09bd58d909b3c50b4ff4480485fa32ad33e4b286/packages/vite/src/node/build.ts#L1172), but this PR is...

The consumer who uses `renderBuiltUrl` will need to encode the `filename` themselves in this case. In my mind, "filename" is un-encoded, and the returned built "url" is encoded. Unless we...

Hmm, maybe I'm also looking at the issue wrongly. @patak-dev I think I agree that perhaps we should leave `renderBuiltUrl` `filename` un-encoded, and also leave its returned url un-encoded so...