Thomas Beutlich

Results 394 comments of Thomas Beutlich

> Will look into it ASAP, I'm overbooked now. @casella Did you find some time to check this meanwhile?

@justnielsen FYI

Needs updating https://github.com/modelica/ModelicaStandardLibrary/wiki/Generating-a-new-MSL-release to also add the binaries to the release asset.

> @beutlich is the update of the https://github.com/modelica/ModelicaStandardLibrary/wiki/Generating-a-new-MSL-release guide the only missing thing to merge this PR? Well, we could also add a deploy stage via CI (either manually or...

> Of course, maybe this deserves a separate ticket on its own? See #4645.

> I find the experiment with coderabbit interesting and the statements look suggestive. However, the summary completely misses the intent of the changes. Yes, it's experimental. The summary feature is...

@AHaumer introduced both unit types by 2e76e29aaa2bf6e2f8c30a342b5a72fdff7c90e7.

> The general idea is good, but when using it outside of functions it becomes messy. I removed the usage in block `Modelica.Blocks.Math.RealToInteger`. @casella @HansOlsson Please add your review again.

> One could possibly add "away from zero" already in description Incorporated. Fell free to review this last change. @henrikt-ma may I kindly ask for a second review. Thanks.

First remarks: * Instead of referencing the outdated page https://doc.modelica.org/om/Modelica.Blocks.Tables.html (of MSL v3.2.3) the latest published version for v4.0.0 is found at https://doc.modelica.org/Modelica%204.0.0/Resources/helpOM/Modelica.Blocks.Tables.html. * Note that it might be useful...