modelica
Are "CircularWaveNumber" and "CircularWavenumber" really two different quantities?
It seems very confusing to offer both of these:
type CircularWavenumber = Real (final quantity="CircularWavenumber", final unit="m-1");
type CircularWaveNumber = Real (final quantity="CircularWaveNumber", final unit="rad/m");
If it is intentional to have two different quantity strings for these, I suggest to at least clearly comment in the code why we have both.
Looks like a pure oversight, most likely due to the non-alphabetic sorting of types which makes it harder to see these. Question is, which of the units should be kept and which should be a pointer (needs to be at least until the next MAJOR version).
@AHaumer introduced both unit types by 2e76e29aaa2bf6e2f8c30a342b5a72fdff7c90e7.
@AHaumer introduced both unit types by 2e76e29.
No, that just touched them.
Before that Dag Brück touched both in 6a90d1a893 and before that in 7366c2 under the name SIunits.mo. That is just version 1.3.1 from 1999 - and we don't have git history before that.
Note that it wasn't Dag's fault, as far as I understand he just uploaded that old version.
Looking at web archives it seems that 1.3.1 was the first released version of the standard library, even though an earlier version was announced; so it seems it is once more an original error that has survived a long time.
Update: Digging even deeper I found it already in version 1.0.1 of MSL where SIunit was split into sub-packages; and Martin Otter and Hubertus Tummescheit (together with Astrid Jaschinski) are listed as original authors.
