Benjamin Huth
Benjamin Huth
I have to admit I did not understood every detail of the clang-tidy integration. It looks quite complicated in total, but I would agree that its great to have a...
Just one question maybe: There are these two files `.clang-tidy` and `.clang-tidy-headers`, and additional to that in the file `cmake/ActsStaticAnalysis.cmake` are also some options defined... Is some of this redundant...
Okay, that sounds reansonable. Let's merge then!
Okay, if we change this I would argue against generating the file in cmake. This has no real advantage I think. Running the cmake-triggered clang-tidy with the global `.clang-tidy` would...
So there still are these failures in the examples tests and physmon tests... It looks like something does not work here with the access of the stored objects I think,...
> I'm noticing that the linux_examples_test is taking very long on this PR. Usually this completes under 20min. Could this be a problem with the change here @benjaminhuth? I'll have...
I think I resolved the problem, there was an uninitialized `ActsExamples::RandomNumbers` object which caused a segfault. Whats a bit strange is that a segfault seems to let the docker container...
Could you re-approve @asalzburger so we can get this in?
Can you re-approve, @paulgessinger ?
> what I didn't/don't understand is what's the difference between your approach > > ``` > ... > { > "volume": 23, > "layer": 2, > "value": [ > {...