Benjamin Huth
Benjamin Huth
Maybe we should also quickly discuss this in tomorrows developer meeting, since it proposes changes to the definition of the public API / the versioning...
Hmm I'm not an expert on github actions, but could this not be done with this? https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#label To trigger these things when the label WIP is deleted...
Ah no sorry, that seems to be related to the global creation and deletion...
https://stackoverflow.com/questions/62325286/run-github-actions-when-pull-requests-have-a-specific-label This seems to adress this... If we add ```yaml on: pull_request: types: [ unlabeled ] ``` would this work? Maybe it would always trigger if we unlabel a PR...
however, its maybe a bit unconvenient to require a empty commit in some cases, but often there will be anyhow a sync with `main` necessary and that should trigger it...
@paulgessinger I tried a bit on my fork to set this up correctely, and I think I found a way to express this: On the requirements the `push` trigger must...
> Can you consider using a pair or separate argument for the min/max values, instead of a `Vector2`? I don't think using `Vector2` brings any tangible benefit, and it might...
Looks good in general :) I just think we should address this one point before merging...
For me this crashes with one thread as well
Hmm it looks a bit different to be honest, but couldn't check in detail for no. I attache my gdb backtrace, maybe this gives a hint. [backtrace.txt](https://github.com/acts-project/acts/files/9724203/backtrace.txt)