acts icon indicating copy to clipboard operation
acts copied to clipboard

refactor: change WhiteBoard backend to std::any

Open benjaminhuth opened this issue 3 years ago • 3 comments

Just a test to see if it would work. Still WIP

benjaminhuth avatar Aug 10 '22 08:08 benjaminhuth

Codecov Report

Merging #1412 (796c495) into main (cd5da0c) will decrease coverage by 0.01%. The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1412      +/-   ##
==========================================
- Coverage   48.58%   48.57%   -0.02%     
==========================================
  Files         381      381              
  Lines       20727    20743      +16     
  Branches     9497     9505       +8     
==========================================
+ Hits        10070    10075       +5     
- Misses       4110     4119       +9     
- Partials     6547     6549       +2     
Impacted Files Coverage Δ
Core/include/Acts/Propagator/StandardAborters.hpp 73.07% <0.00%> (-3.52%) :arrow_down:
...de/Acts/TrackFinding/CombinatorialKalmanFilter.hpp 32.67% <0.00%> (-0.33%) :arrow_down:
Core/include/Acts/Seeding/Seedfinder.ipp 0.00% <0.00%> (ø)
...rc/TrackFinding/CombinatorialKalmanFilterError.cpp 0.00% <0.00%> (ø)
Core/include/Acts/Propagator/AbortList.hpp 81.81% <0.00%> (+1.81%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov[bot] avatar Aug 10 '22 09:08 codecov[bot]

This issue/PR has been automatically marked as stale because it has not had recent activity. The stale label will be removed if any interaction occurs.

stale[bot] avatar Sep 20 '22 19:09 stale[bot]

So there still are these failures in the examples tests and physmon tests... It looks like something does not work here with the access of the stored objects I think, but currently fixing this is not my priority. I'll leave the PR open for now, so if someone has an idea whats going on here we can proceed on this.

benjaminhuth avatar Oct 12 '22 08:10 benjaminhuth

what was the problem with these changes @benjaminhuth ? I might want to follow up on this later

andiwand avatar Nov 07 '22 08:11 andiwand