Benjamin Huth

Results 63 comments of Benjamin Huth

Hmm I wonder: Do we need `joinPaths` at all? Or can't we just switch wo working completely with `std::filesystem::path` objects here? and only use the `/` operator? Same with `getWorkingDirectory`,...

tagging @paulgessinger @andiwand on this.

Hmm because we have these livetime issues: What is actually the reason, that the Surface cannot own its detector element? like this: ```c++ class Surface { // ... const DetectorElementBase...

Hmm I added it also for clang... but actually, I do not check which stdlib is used. Maybe we should add both macros unconditionally of the `CMAKE_COMPILER_ID`. Regarding the option,...

Okay yeah that makes sense, `ACTS_FORCE_ASSERTIONS` seems a good place to do this I haven't though of.

But just out of interest @paulgessinger: To me every standard library assertion would be a violated precondition, so what would be the issue with enabling them for `RelWithDebMode`? GCC documentation...

Yeah I agree that its a huge change, but would be a good change in my opinion. But yeah, I wasn't aware that by default acts is build in RelWithDebInfo...