Benjamin Huth
Benjamin Huth
@toyamaza This is the (still drafty) PR, hope to get it in soon. But before I want to add at least a little unit-test to ensure the log-parsing doesn't break.
I have compressed the images to ~500K, and updated the documentation with a bit of text.
Okay, sure, but compilation fails in that case I think (at least that was what I experienced). Do we test the case where no TBB is present? Shouldn't we use...
I think you're right @timadye: I should try to reproduce the compile failure. Anyhow: I think if `ACTS_USE_EXAMPLES_TBB=ON` and TBB is not found, we should fail the cmake configuration. maybe...
I found the source of the compile errore: The track finding algorithm unconditionally uses `tbb::combinable` because of the memory statistics. Should we hide this behind a preprocessor define @paulgessinger ?...
Okay, during testing I found an additional place with explicit TBB dependency: https://github.com/acts-project/acts/blob/7c272316b739a72bf45d92e5eb336295e5b41201/Examples/Framework/include/ActsExamples/Framework/Sequencer.hpp#L174 Actually since this involves the FPE mechanism I would now lean towards dropping the possibility to build...
I think that these build errors were not observered for such a long time also indicates the option is not widely used.
> Do these direct uses of `tbb` conflict with `tbbWrap`'s other function of bypassing `tbb` setup when running in a single-threaded mode? That definitely was useful to simplify debugging. I...
I would be fine closing this, since most people seem fine with using ninja + regex, and this should also work fine for me. In the spirit "the less build...
Let's close it for now, I don't have the motivation currently to make this clean. If I ever feel like needing this in the future, I can still reopen it.