Bryan Boreham

Results 1003 comments of Bryan Boreham

Can you use `SizeOfLabels` for this? Something like `l.Range( { ... SizeOfLabels(name, value, 1) }`.

Per standard Prometheus rules, changes on performance grounds should be supported by a benchmark.

Sure, thanks for your interest. It would be good to have a small benchmark, to check that your changes run at about the same speed.

Hello from the bug-scrub! While this is a valid feature request, as far as we know nobody has worked on it, and it is a large (many months) project. Most...

Glad to see this make some progress. Ideally I would like to see this kind of implementation take over from usage groups, in simple cases. So it would be good...

Hello from the bug-scrub! The solution should be similar to `BenchmarkRemoteWriteHandler`, but for the V2 format. Possibly similar to how `BenchmarkBuildWriteRequest` and `BenchmarkBuildV2WriteRequest` are constructed.

Hello from the bug-scrub! Not much movement on this PR, but it looks like something we would want to improve. I understand @Harkishen-Singh is no longer active in Prometheus, so...

Hello from the bug-scrub! @sujalshah-bit do you have any response to the last comment?

On principle we should not remove a feature from Prometheus because it causes a problem in a project using the code downstream. If someone saw this effect in Prometheus itself...

I wrote down some of the core behaviors of the engine at https://grafana.com/blog/2024/10/08/inside-promql-a-closer-look-at-the-mechanics-of-a-prometheus-query/. This is not so much "what does PromQL mean"; more "how does Prometheus currently implement PromQL".