Bryan Boreham

Results 1002 comments of Bryan Boreham

How about a role for someone who undertakes to hang out in #sig-network on Slack and give pointers to people who show up with generic questions (e.g. "that would be...

What would be the difference from `prometheus_tsdb_head_samples_appended_total` ?

If you're going to change this, why go via strings at all? Isn't it logically more like an enum?

I mean `ErrorType` would become an `int` type so we're not hashing string values every time we use it.

Hello from the bug-scrub! @juliusv and @Nexucis: what do you think about @Pionerd's latest?

> For example, my conclusion from the following statement is that an exporter MUST retry HTTP 408 and all 5xx response codes. I'd just like to record that "408" was...

I remarked on the amount of memory allocations it does. Looks like this was improved recently, with the addition of a pool in https://github.com/mostynb/go-grpc-compression/commit/629c44d3acb9624993cc7de629f47d72109e2ce5. Someone else commented https://github.com/mostynb/go-grpc-compression/issues/25

Hello from the bug-scrub! Seems that the underlying issue was fixed in #14078, and the benchmark was added. So can this PR be simplified?

We reviewed all submissions in detail. We looked for an understanding of the project, an ability to do it (not in a full-time job for instance), and anything else that...