Bryan Boreham

Results 962 comments of Bryan Boreham

Hello from the bug-scrub! Do you think you will come back to this @hainenber , or shall we just close it?

Hello from the bug-scrub! Since https://github.com/prometheus/common/pull/416 was merged, I guess we would not merge this PR. @fholzer can you please close it or update what else needs to be done?

No update in >6 months so closing. Please open a new PR if there is more to do.

I'm interested why this test goes in via the http interface. Is that important for behaviour or timing, or it simplifies the recreation?

You can have a flag to set the value used for this check, without having it affect other things.

@zhangfanv can you clarify why you don't think this is a duplicate, please?

@oceakun go ahead! I suspect that making tests will be the hard part.

Can you say a bit more about why you want this change, please?

I started looking at this; my idea is that we can use the protobuf-encoded LabelPairs as the key to the scrape cache.