Bryan Boreham

Results 668 comments of Bryan Boreham

Since the `go` subtree is a copy of that part of the Go distribution, it seemed to me that overriding the `pathToName` function would be nicer than hacking the code...

@jwendel @shahuwang you might like to try #61 as an alternative solution

Now I believe this is obsoleted by #62

I didn’t understand “cannot find the process owning it”. What if the process has exited?

Ack. It hasn't been high enough up my priority list lately.

Rebased and added unit tests for the Inject/Extract functionality added in this PR. Note that `ot.HTTPHeadersCarrier` needs special treatment - `Set()` modifies the keys to meet HTTP header expectations -...

> Does https://github.com/open-telemetry/opentelemetry-go/pull/2911 meet the needs here Strictly no, however I think #2911 makes it easier to work around the deficiency. ~Perhaps you will update the [doc](https://github.com/opentracing/opentracing-go/blob/10b1cf09e00bdc84234b8c7a4b4d4e4afe64de87/propagation.go#L71) says it should...

Consistency is a fine thing, but I would expect blogs, books, etc., to advise “never call `ReadAll`“ if it remains as is. Stretching my imagination, some cases can avoid memory-growing:...

@CAFxX can you clarify how this helps with the resizing of the destination buffer?