Bryan Boreham

Results 968 comments of Bryan Boreham

Hello from the bug-scrub? @aknuds1 could you take another look please? @wangzhao765 note there is now a merge conflict as one of the tests has changed on main.

It's done on the write path here: https://github.com/grafana/mimir/blob/a479a81bc84fca26b4a41aa93b7fa32d09cd2ab4/pkg/distributor/push.go#L162-L165

Hello from the bug-scrub! @roidelapluie would it be OK to merge this and then try to do the better thing after?

In #549 you added `Host` to `HTTPClientConfig` and `host` to `httpClientOptions`. Since only the latter was used, I removed the former. Now you adding it back, and hopefully using it....

Thanks for the explanation. It's fine, everybody makes mistakes. Just easier for me to follow if I can see the path. However we may prefer to deprecate the un-needed one...

Please can you post the relevant metrics being scraped, so I can understand your issue better. I.e. use a browser or curl to fetch the raw text from http://10.144.30.86:9983/metrics, and...

Hello from the bug-scrub! @Codelax it looks like the last review requested an additional comment - do you have a response to that? Thanks!

Hello from the bug-scrub! @harry671003 do you think you will come back to this? Please also comment on the benchmark results that Arve posted.

Discussed at the bug-scrub again; @jesusvazquez would you be able to take a look? I think if it works in Thanos we don't need to worry too much about it.