Bryan Boreham

Results 835 comments of Bryan Boreham

I think your approach is taking advantage of being able to read the entire buffer in one go. This is not possible when reading from a socket, as in the...

Sorry, going a bit too fast. I corrected the Prometheus client-library version to return the body, and the benchmark results are the same. Maybe it's just that your test response...

As we approach a year since support for this was added in Prometheus, can I re-raise this request for Grafana Prometheus datasource to use the better API.

I'm not sure if there is a clean way to get the version from the backend: Cortex/GEM will not answer `/status/buildinfo` (and doesn't map to a released Prometheus version), and...

Results of trying this out - solid lines are incidences of the error, and dotted line is when we rolled out the fix. ![Screenshot from 2022-05-05 11-02-47](https://user-images.githubusercontent.com/8125524/166944389-15f40481-c1fa-497c-86a4-b4343934768f.png)

Was this change made somewhere else?

I see it's been added to a [1.13.0 milestone](https://github.com/prometheus/client_golang/milestone/4), but no date attached.

Prometheus client library has now been released with the fix. https://github.com/prometheus/client_golang/releases/tag/v1.13.0

There is a [cni-dev mailing list](https://groups.google.com/forum/#!forum/cni-dev) which is extremely low volume, and CNI release instructions say to announce on that.

Suggest you should document this usage, if it is intentional. The docs on `honor_label` tend in the opposite direction: ``` # Note that any globally configured "external_labels" are unaffected by...