Bryan Boreham

Results 948 comments of Bryan Boreham

> as we build labels.Labels from this anyway later on This is only true the first time you see one particular series; after that the Labels are held by the...

If we can find a token to cache from then we don't need to worry about the strings.

Hello, this came back around at the bug-scrub. We commented that this PR is aimed at unit-tests within promtool, but it would also be useful to have a tool which...

Hello from the bug-scrub! There are still a couple of review comments open, plus a lint warning, and some merge conflicts. @bradbeam are you able to fix those up? @krajorama...

Thanks for this. Is it only partially undone? Please open an issue with details if there was something that worked before and doesn’t work after the fix. You reminded me...

There is one change I would perhaps document as “mixing samples of the same series with and without timestamps is now rejected.”

Also we only want one line in CHANGELOG for #12933, not one saying CHANGE and one saying ENHANCEMENT.

Hi, reading the description, I wondered if you looked at handling deltas inside TSDB. So we wouldn't need an extra copy of the current value, just add each delta on...

> replace samples I meant create a new sample whose value is the last value plus the delta.

Hello from the bug-scrub! No update in 7 months so closing. If you would like to come back to it, please comment here and we can re-open. Thanks!