Bartosz Blimke
Bartosz Blimke
Thank you @mikegee This should help when developing the fix.
Can you please include the spec that demonstrates why these 3 lines are needed? Without a filing spec there is no reason for them to be there :)
@pedrocarmona thanks for explaining the issue. I believe `if defined?(::Patron::Session)` should be enough, there is no need to check for `if defined?(::Patron) && defined?(::Patron::Session) `
@kwstannard I understand the issue and what you're trying to achieve. However, this isn't something WebMock is designed to handle. WebMock uses global registries in the current process's memory and...
@ouranos thank you! If we add support for [this](https://github.com/bblimke/webmock/blob/135a44446ee6d323e9970f39424ab5c6ec3efcc0/lib/webmock/request_signature.rb#L41) then the failure output on non matching requests will be nicer, therefore I'd be keen to add support for that.
@ouranos please merge from master. I have fixed specs under jruby.
@twolfson thank you for submitting this pull request and for an attempt to improve the previous solution. Unfortunately your solutions still has the same problems as the previous one. First...
Yes, people usually set only one stub per example - usually. The code needs to be deterministic though. You are right that times matcher has exactly the same issue if...
@foca thank you for reporting. In case of Curb, one needs to set `follow_location` to true. I believe Patron follows redirects by default. I also noticed that Curb adapter doesn't...
Can you please provide a failing code example?