Bartosz Blimke
Bartosz Blimke
@sealabcore Thank you for your work on this PR. I've noticed that while the tests in master are now passing, there aren't any new tests associated with this specific change....
@JanDintel thank you for the pull request. Could you please describe the reasons behind this pull request? I get the idea, but I'm not sure it's necessary or desired. If...
I get your point. Following your reasoning, shouldn't that be the same for other content types? I.e XML or form url encoded body? I'm concerned about custom `elsif @pattern.is_a?(String) &&...
@JanDintel ok, let's keep the current behaviour, but review the pull request if someone reports this issue again.
@Fivell After reviewing that PR I still not entirely convinced this should be merged, but perhaps you can convince me :) Have you reviewed the comments above? How did you...
@danielkaczmarczyk, thank you for bringing up this issue again, and I apologize for the hours you had to spend debugging it. After reviewing all the previous comments in this thread...
I submitted an issue to Crack gem. The main reason to have own parsing is that WebMock doesn't have to depend on any gem at runtime (no need to depend...
Taking into account lack of response from Crack issue I may just change json parser used in WebMock. Perhaps to okjson.rb from rack, but by adding it under WebMock rather...
@johngallagher all tests in master branch are passing now, therefore feel free to marge master branch to this one.
> I'm getting a ton of unrelated CI failures locally - no idea what's going on here. > > These tests are all failing on `master` branch: Tests on master...