webmock icon indicating copy to clipboard operation
webmock copied to clipboard

Add JSON API support

Open ouranos opened this issue 7 years ago • 5 comments

Add support for JSON API.

This makes hash_including works properly with JSON API requests.

Not sure if I need to change this part too?

I wasn't sure which specs to update, let me know if you need me to add anything else.

ouranos avatar Dec 28 '17 01:12 ouranos

@ouranos thank you!

If we add support for this then the failure output on non matching requests will be nicer, therefore I'd be keen to add support for that.

bblimke avatar Jan 03 '18 00:01 bblimke

Ok, I'll add it then.

Any ideas why the specs are failing? It doesn't seem to be related to my changes.

ouranos avatar Jan 03 '18 01:01 ouranos

@ouranos please merge from master. I have fixed specs under jruby.

bblimke avatar Jan 03 '18 01:01 bblimke

Rebased from master and added RequestSignature support. Let's see if the build pass.

ouranos avatar Jan 03 '18 01:01 ouranos

This PR should fix the JSON API support, in a more generic way (and allows further content type customization): https://github.com/bblimke/webmock/pull/763 Since JSON API is not that widely adopted yet, I wouldn't add it to the default content types. Of course it would also be fine to have both solutions.

hoenic07 avatar Jun 07 '18 12:06 hoenic07