Bartosz Blimke comments

Results 218 comments of


                                            Bartosz Blimke

make a 1.0.0 release?

@kiskoza, I would also suggest considering gemspecs, not just Gemfiles. For example, the `crack` dependency declaration in WebMock is via gemspec, not Gemfile. Here is a list of the most...

Enable handling of multipart/form-data content

@kwstannard thank you. I will revisit support for multipart and your changes when I find some time

`uri` method on mocked `Net::HTTPOK` incorrectly returns nil

The fix is now released in version 3.21.1

can't modify frozen String: ""

Thank you for reporting, @utkarsh2102 and @Nakilon. I've addressed the issue by updating the response body to an empty, unfrozen string. This change will be included in the upcoming release.

Error checking doesn't recognize hashes and provide the intended help

Thank you @jakerobb This is now fixed in 3.21.2 release.

Cannot use the same url twice

@rdptz can you please provide the sample code to reproduce the problem? your example doesn't have any code that executes the request. Do you have `require 'webmock/rspec'` in your rails_helper.rb?

FEATURE: implement body streaming for Net::HTTP

@SamSaffron Thank you for the PR and the delightful AI conversation transcript! 😄 It's the first PR I've received with an attached AI discussion, and I appreciate the attempt! Apologies...

FEATURE: implement body streaming for Net::HTTP

@SamSaffron thank you for your prompt feedback. I do agree that adding :body_chunks will make the API more complicated. I'm concerned about people declaring arrays of strings as the response...

httpstat.us site used by many tests is defunct

@tmertens thank you for reporting. it looks like httpstat.us was just temporarily down, as it works fine now. I do agree it would be best to replace httpstat.us with a...

Fix `transfer-encoding` header for requests using AsyncHttpClientAdapter raise exception

@tmertens thank you for investigating and explaining the issue and for the PR. I appreciate the proposed fix, but I'm uncertain if it's the right approach. As far as I...