Bartosz Blimke comments

Results 218 comments of


                                            Bartosz Blimke

fix: Support Addressable::URI in request patterns

Hey @ixti, Thank you for the PR. If passing Addressable::URI as a request pattern worked, it was only accidental, as this was never officially supported. The change introduced in https://github.com/bblimke/webmock/commit/f651c254a3a8d75ec3b2bef73bae35979c9ae5fc...

fix: Support Addressable::URI in request patterns

@ixti Thank you. Supporting Addressable::URI is ok. My main consideration was avoiding unnecessary feature additions that would increase maintenance overhead. If there's significant user demand for Addressable::URI support, I'm happy...

fix: Support Addressable::URI in request patterns

Thank you @ixti It's released.

WebMock with allow net connect mangles and unbuffers streamed responses

@SamSaffron do I understand correctly that the problem only exists for gzipped responses?

WebMock with allow net connect mangles and unbuffers streamed responses

@babelfish could you please provide an example? why would a single chunk be invalid json?

WebMock with allow net connect mangles and unbuffers streamed responses

@babelfish thank you. That makes sense. Webmock's Response would have to hold a collection of chunks in order to handle that instead of a single response body string.

Intermittent NetConnectNotAllowedError because stub_requests unexpectedly empty

@dan-jensen have you investigated that further? Do you have any more details?

`enable_net_connent!()` with a block

@yegor256 I like this idea. It would definitely be more convenient! However, it's not as straightforward as it seems. Both `disable_net_connect` and `enable_net_connect` take options that modify WebMock's global state....