Asvin Balloo

Results 128 comments of Asvin Balloo

@eclarke1 @FlicHollis Just a note that this is blocked until #4878 is finalized. The IB is almost done and just waiting for #4878 to be finalized.

@aaemnnosttv @tofumatt I spent some time looking into this and I think the issue is the height of the overlay is calculated before the widgets are rendered, the main culprit...

@aaemnnosttv I'am pretty sure it's PSI widget the culprit here. I would suggest we keep the ticket open until https://github.com/google/site-kit-wp/issues/4878 is merged, just to make sure.

Sounds good @FlicHollis , taking a look 😁

@kuasha420 @tofumatt A note about the following: > If " Other" option is picked and the text field is empty when user clicks "Next/Review", an error message should be displayed...

Update after spending some time on the ticket: - Have yet to determine the cause of the issue - Tried loading fonts within Storybook differently, using webfontloader and trigger backstop...

Latest updates: - Fonts are not rendering even though technically they are loaded. Reference: ![image](https://user-images.githubusercontent.com/31818/192775444-a5e5546a-a5c4-4d79-bcf6-ed08cb3ee9fe.png) Test: ![image](https://user-images.githubusercontent.com/31818/192775503-8536cae5-8266-4a06-a0e2-9ba11ae5eb59.png) - No improvements noted when increasing the `delay` in `tests/backstop/config.js` - The same...

@aaemnnosttv Not sure if am missing something here and how the GH actions are all passing, but if you look at one of the [reference image on develop](https://github.com/google/site-kit-wp/blob/develop/tests/backstop/reference/google-site-kit_Settings_Connected_Services_0_document_0_small.png) and you...

@sashadoes Thanks for the IB and I suggest we make the following tweaks to it: * Let's avoid putting code in the IB as it can prompt the engineer working...