Asvin Balloo comments

Results 128 comments of


                                            Asvin Balloo

Onboarding: Create new Ads account when there are existing accounts in Google Accounts Card

@joemcgill I've added the IB and do you think we need the confirmation modal? Right now, when you want to create a new Ads account, the `TermsModal` is displayed which...

Onboarding: Create new Ads account when there are existing accounts in Google Accounts Card

Thanks @joemcgill . IB has been updated to reflect this.

Onboarding: Create new Ads account when there are existing accounts in Google Accounts Card

`WarningModal` has been renamed to `ConfirmCreateModal` in the IB. Thanks @joemcgill

Onboarding: Create new Ads account when there are existing accounts in Google Accounts Card

@eason9487 Maybe we can update the copy during implementation? cc @joemcgill

Onboarding: Create new Ads account when there are existing accounts in Google Accounts Card

Sure thing @joemcgill . IB has been updated to account for the new button.

Add minimum budget limit

Thanks @joemcgill . @ankitguptaindia This is ready for QA. E2E tests passing: https://github.com/woocommerce/google-listings-and-ads/actions/runs/10908719300/job/30275338551

Add minimum budget limit

@joemcgill Can you kindly review the PR again please? Summary of what was added: 1. A new `useValidateCampaignWithCountryCodes` which is meant to work with "dynamic" country codes. For e.g once...

Add minimum budget limit

Thanks @joemcgill . I've updated `useFetchBudgetRecommendationEffect` to not fetch if there are no `countryCodes`.

Add minimum budget limit

@ankitguptaindia 1. You're right. This will be handled in #2552 2. I pushed a fix and it should be ok now. The "Complete setup" should be disabled. One thing I...

@eason9487 Thanks for your thorough review. I addressed your comments. However I wanted to check with you about the approach for not making several requests to `/ads/campaigns/budget-recommendation`. Was there any...