Asvin Balloo
Asvin Balloo
@joemcgill The PR is no longer relevant unfortunately. I'll close it in favour of https://github.com/woocommerce/google-listings-and-ads/pull/2623
@joemcgill Can you kindly review the IB please? Thanks!
@eason9487 I added a "Notes" section in the IB to clarify when to switch to compact or stay in edit mode. cc @joemcgill
@eason9487 , @joemcgill Correct me if am wrong, but the "Edit" button will be displayed only when all the 3 accounts are connected 🤔 The brief looks good @joemcgill ,...
@dsawardekar PR has been updated to add the style updates. Let me know if i've missed anything.
@dsawardekar Can you kindly fix the merge conflicts please, then I'll review the PR. Just FYI, we removed the Audience section from the paid ads setup: https://github.com/woocommerce/google-listings-and-ads/pull/2551
@joemcgill I made a few tweaks to @dsawardekar 's PR. Can you kindly review please? Thanks!
@joemcgill I made a few updates to the PR. Can you kindly take a look please? Thanks!
@dsawardekar @joemcgill In that case maybe we need to rename the label to what we have in the [new designs](https://www.figma.com/design/fqR0EHi63lWahRcVTKCcba/Google-Listings-%26-Ads-v2.x?node-id=7293-237837&node-type=frame&t=clG1ewJeSswzRor6-0) which is more generic and it prompts the user to...
@ankitguptaindia I added a note in the "Technical decisions": > To maintain consistency with MerchantCenterSelectControl, the Select one label has been removed from AdsAccountSelectControl: https://github.com/woocommerce/google-listings-and-ads/pull/2608/files#diff-3c83d48212438511a41629a8f6b02ac7666ca664d0c25a734497a1416856d115L17 @joemcgill What do you think?...