Asvin Balloo

Results 128 comments of Asvin Balloo

@eason9487 Can you review proposed changes please? We are now calling the `useFetchBudgetRecommendation` hook in the `BudgetSection` component (https://github.com/woocommerce/google-listings-and-ads/pull/2552/files#diff-930c930d2c6b54b942dd7cecad526e73a68845aece1d8cb09885f1aa8c43a1e9R55) which is displayed once a Google Ads account is connected. Furthermore,...

@joemcgill The `tourChecked` property from the `useTour` hook should be able to do that. I see existing tours have been implemented the same way 😁

Thanks @joemcgill . I've updated the IB for https://github.com/woocommerce/google-listings-and-ads/issues/2828 to include a custom `Pagination` component because we cannot use the default one which comes with `DataViews`.

@tomalec From my tests, the `@wordpress/dataviews` package is not bundled in WP. See: https://github.com/WordPress/gutenberg/blob/trunk/tools/webpack/packages.js#L38 Also also, the package is [not present here](https://github.com/WordPress/WordPress/tree/master/wp-includes/js/dist).

@joemcgill @tomalec Just a note that I've updated the IB to include custom pagination following the [following comment](https://github.com/woocommerce/google-listings-and-ads/issues/2830#issuecomment-2767420105).

@ankitguptaindia Please note that as per the following [conversation](https://github.com/woocommerce/google-listings-and-ads/pull/2853#discussion_r2049513637), we have removed any custom styles for the `DataViews` component. That means that the table will not match the designs exactly.

Thanks, @joemcgill . I've updated the IB to include the `onPriceChange` prop. While `onActionPerformed` from `RenderModal` would have been ideal, it's not applicable here (see notes in the task description)....

@joemcgill IB has been updated taking into considerations the latest changes.

@joemcgill 1. Designs have been finalized 😁 . I've updated the ticket description to reflect that. 2. Thinking back, I don't think we need another endpoint. Here is what I...

> Thanks [@asvinb](https://github.com/asvinb). The updates look good. I'll create a new back-end ticket to enhance the `mc/price-benchmarks` endpoint with the necessary data. > > Another thing we will need to...