Asvin Balloo comments

Results 128 comments of


                                            Asvin Balloo

Successful set up banner icon is small as compare to Figma design

Thanks @sashadoes . A few more tweaks: 1. Can you update the "Test Coverage" section to remove unit tests and instead add scenarios within the VRT suite? 2. Let's make...

Successful set up banner icon is small as compare to Figma design

@sashadoes IB looks good. However can you let me know about the following? > Can you let me know about the height of the SVG? As per my previous comment,...

Successful set up banner icon is small as compare to Figma design

Thanks @sashadoes . LGTM. For future IBs, instead of adding the height and width of the SVGs in the IB, you can just say to style the SVG as per...

Successful set up banner icon is small as compare to Figma design

IB 👍

Successful set up banner icon is small as compare to Figma design

@tofumatt Can you review [followup PR](https://github.com/google/site-kit-wp/pull/6127) please? Basically there was a CSS regression but most importantly the [Idea Hub notification](https://google.github.io/site-kit-wp/storybook/main/?path=/story/modules-idea-hub-notifications-promptbannernotification--ready) is different from other notifications due to the large SVG....

Bug/#5110 fix php81 warnings

@kuasha420 I'am on PHP 8.1.9 where i can see those errors via QueryMonitor.

Bug/#5110 fix php81 warnings

@kuasha420 I checked there are no no longer warnings from our code. I'll let @eugene-manuilov @aaemnnosttv check the `ReturnTypeWillChange` attribute

Add the Audience Tiles widget (Storybook)

Thanks @eugene-manuilov . Let me know if it's clearer now. Thanks!

Add the Audience Tile happy path view (Storybook)

Thanks @eugene-manuilov . Let me know if it's clearer now. Thanks!

The expression evaluated to 'undefined' ...

👋 @Anber , indeed I have multiple entry points. 👍