Arjo Chakravarty
Arjo Chakravarty
Part of me wonders if we should batch run `sed` on all of these models to remove gazebosim. Or do something in the fuel frontend to give a warning if...
Can you fix your commit sign-off. Instructions are [here](https://github.com/gazebosim/gz-sim/pull/2241/checks?check_run_id=18841120789)
> I hope its okay that I squashed and force pushed, I didnt intent to remove the co-author commits, but rather keep the history much more clearer. No worries. You...
Yes currently the `SystemManager` does not support removal of plugins. This seems to be something that can be fixed, but will take some amount of effort.
Yeah. That is expected I'm currently working on a fix for it here: #2232
I've reworked and simplified things significantly. We don't use barriers any more. Instead just like during addition, during removal we simply destroy all threads in the `PostUpdate` thread pool. The...
Not sure why I'm getting do many dartsim related errors. Can't reproduce locally: ``` libgz-physics-dartsim-plugin.so: undefined symbol: _ZN3sdf3v158internal17SdfScopeDelimiterB5cxx11Ev ```
Thanks @scpeters, I've addressed your feedback. Would like the :heavy_check_mark: from @azeey as well, then we can go ahead and merge this. Thanks for everyone's help on this!
Thanks everyone for your guidance! Seems like our homebrew build is blocking the merge.
Yeah mabel is right. I think I got confused by the deletion of some of the files.