Ankit Gade

Results 105 comments of Ankit Gade

Thanks for testing this @mohitwp and highlighting the issue. I have raised a [follow-up PR](https://github.com/google/site-kit-wp/pull/9652) for this problem.

Thank you @joemcgill for your feedback. I've addressed your comments and responded to one of your comments related to removing the response promise [here](https://github.com/woocommerce/google-listings-and-ads/pull/2552#discussion_r1731898598). Please let me know if there's...

@joemcgill Thanks for the video. It helped me understand the issue well. The issue was happening because `PaidAdsSetupSections` component was getting rendered before `recommendationData` is resolved. There was also an...

Hi @joemcgill Apologies for missing the comment previously. I have responded to the query [here](https://github.com/woocommerce/google-listings-and-ads/pull/2552#discussion_r1731898598)

@asvinb I've created the new hook `useBudgetRecommendationData`, but kept the `useEffect`in same component because if we move up to `SetupAdsForm` component as well as for `CreatePaidAdsCampaign`, it will create the...

Thank you @nfmohit for reviewing the PR and adding the feedback. I've addressed the feedback and left response for couple of comments. Over to you for another round of review....

Thanks @nfmohit for reviewing this. Sorry for missing couple of points from previous one, did not notice that there was a response added. I have made the changes requested by...

Thanks @nfmohit . I've made the changes and assigned to you to merge this.

There are some table design concerns raised by @ankitguptaindia in #2826 which should be handled as part of this issue, so just adding a note here. Here's the [comment](https://github.com/woocommerce/google-listings-and-ads/pull/2839#issuecomment-2793765106) which...

@ivonac4 @techanvil Can we pull in this issue in the upcoming sprint as this issue still persists?