Improve publication onboarding state synchronization.
Summary
Addresses issue:
- #9149
Relevant technical choices
PR Author Checklist
- [x] My code is tested and passes existing unit tests.
- [ ] My code has an appropriate set of unit tests which all pass.
- [x] My code is backward-compatible with WordPress 5.2 and PHP 7.4.
- [x] My code follows the WordPress coding standards.
- [x] My code has proper inline documentation.
- [x] I have added a QA Brief on the issue linked above.
- [x] I have signed the Contributor License Agreement (see https://cla.developers.google.com/).
Do not alter or remove anything below. The following sections will be managed by moderators only.
Code Reviewer Checklist
- [ ] Run the code.
- [ ] Ensure the acceptance criteria are satisfied.
- [ ] Reassess the implementation with the IB.
- [ ] Ensure no unrelated changes are included.
- [ ] Ensure CI checks pass.
- [ ] Check Storybook where applicable.
- [ ] Ensure there is a QA Brief.
- [ ] Ensure there are no unexpected significant changes to file sizes.
Merge Reviewer Checklist
- [ ] Ensure the PR has the correct target branch.
- [ ] Double-check that the PR is okay to be merged.
- [ ] Ensure the corresponding issue has a ZenHub release assigned.
- [ ] Add a changelog message to the issue.
Build files for 2b2cef72f38e21deac672ca89cebe7888db5ef30 have been deleted.
Size Change: +175 B (+0.01%)
Total Size: 1.88 MB
| Filename | Size | Change |
|---|---|---|
./dist/assets/js/googlesitekit-entity-dashboard-********************.js |
81.8 kB | +127 B (+0.16%) |
./dist/assets/js/googlesitekit-main-dashboard-********************.js |
161 kB | +145 B (+0.09%) |
./dist/assets/js/googlesitekit-modules-reader-revenue-manager-********************.js |
40.8 kB | -97 B (-0.24%) |
ℹ️ View Unchanged
| Filename | Size |
|---|---|
./dist/assets/css/googlesitekit-admin-css-********************.min.css |
59.9 kB |
./dist/assets/css/googlesitekit-adminbar-css-********************.min.css |
11.8 kB |
./dist/assets/css/googlesitekit-authorize-application-css-********************.min.css |
846 B |
./dist/assets/css/googlesitekit-wp-dashboard-css-********************.min.css |
8.2 kB |
./dist/assets/js/32-********************.js |
2.76 kB |
./dist/assets/js/33-********************.js |
2.25 kB |
./dist/assets/js/34-********************.js |
3.64 kB |
./dist/assets/js/35-********************.js |
935 B |
./dist/assets/js/36-********************.js |
893 B |
./dist/assets/js/37-********************.js |
1.61 kB |
./dist/assets/js/38-********************.js |
1.57 kB |
./dist/assets/js/39-********************.js |
1.61 kB |
./dist/assets/js/40-********************.js |
1.59 kB |
./dist/assets/js/41-********************.js |
1.83 kB |
./dist/assets/js/42-********************.js |
3.11 kB |
./dist/assets/js/analytics-advanced-tracking-********************.js |
901 B |
./dist/assets/js/googlesitekit-activation-********************.js |
24 kB |
./dist/assets/js/googlesitekit-ad-blocking-recovery-********************.js |
55 kB |
./dist/assets/js/googlesitekit-adminbar-********************.js |
34.6 kB |
./dist/assets/js/googlesitekit-api-********************.js |
10.1 kB |
./dist/assets/js/googlesitekit-components-gm2-********************.js |
6.17 kB |
./dist/assets/js/googlesitekit-components-gm3-********************.js |
10.1 kB |
./dist/assets/js/googlesitekit-consent-mode-********************.js |
25.6 kB |
./dist/assets/js/googlesitekit-data-********************.js |
2.37 kB |
./dist/assets/js/googlesitekit-datastore-forms-********************.js |
8.97 kB |
./dist/assets/js/googlesitekit-datastore-location-********************.js |
2.08 kB |
./dist/assets/js/googlesitekit-datastore-site-********************.js |
20.5 kB |
./dist/assets/js/googlesitekit-datastore-ui-********************.js |
10.1 kB |
./dist/assets/js/googlesitekit-datastore-user-********************.js |
27.2 kB |
./dist/assets/js/googlesitekit-events-provider-contact-form-7-********************.js |
646 B |
./dist/assets/js/googlesitekit-events-provider-easy-digital-downloads-********************.js |
624 B |
./dist/assets/js/googlesitekit-events-provider-mailchimp-********************.js |
630 B |
./dist/assets/js/googlesitekit-events-provider-ninja-forms-********************.js |
712 B |
./dist/assets/js/googlesitekit-events-provider-optin-monster-********************.js |
675 B |
./dist/assets/js/googlesitekit-events-provider-popup-maker-********************.js |
634 B |
./dist/assets/js/googlesitekit-events-provider-woocommerce-********************.js |
657 B |
./dist/assets/js/googlesitekit-events-provider-wpforms-********************.js |
633 B |
./dist/assets/js/googlesitekit-i18n-********************.js |
3.93 kB |
./dist/assets/js/googlesitekit-modules-ads-********************.js |
33.4 kB |
./dist/assets/js/googlesitekit-modules-adsense-********************.js |
117 kB |
./dist/assets/js/googlesitekit-modules-analytics-4-********************.js |
184 kB |
./dist/assets/js/googlesitekit-modules-********************.js |
22.2 kB |
./dist/assets/js/googlesitekit-modules-pagespeed-insights-********************.js |
22.8 kB |
./dist/assets/js/googlesitekit-modules-search-console-********************.js |
64.9 kB |
./dist/assets/js/googlesitekit-modules-sign-in-with-google-********************.js |
24.3 kB |
./dist/assets/js/googlesitekit-modules-tagmanager-********************.js |
32.2 kB |
./dist/assets/js/googlesitekit-notifications-********************.js |
22.8 kB |
./dist/assets/js/googlesitekit-polyfills-********************.js |
377 B |
./dist/assets/js/googlesitekit-settings-********************.js |
126 kB |
./dist/assets/js/googlesitekit-splash-********************.js |
68.9 kB |
./dist/assets/js/googlesitekit-user-input-********************.js |
43.6 kB |
./dist/assets/js/googlesitekit-vendor-********************.js |
322 kB |
./dist/assets/js/googlesitekit-widgets-********************.js |
96.2 kB |
./dist/assets/js/googlesitekit-wp-dashboard-********************.js |
62.6 kB |
./dist/assets/js/runtime-********************.js |
1.4 kB |
Thank you @nfmohit for reviewing the PR and adding the feedback. I've addressed the feedback and left response for couple of comments.
Over to you for another round of review.
Thanks again.
Thanks @nfmohit for reviewing this. Sorry for missing couple of points from previous one, did not notice that there was a response added.
I have made the changes requested by you and sending it your way again for a review.
Thanks.
Thanks @nfmohit .
I've made the changes and assigned to you to merge this.