Ankit Gade

Results 105 comments of Ankit Gade

Thank you @techanvil . I've updated the IB so that we never set `publicationOnboardingStateChanged` to `false` in cron. We will set `publicationOnboardingStateChanged` to `false` in `useEffect` hook of the component....

Thanks @techanvil . I simply changed `initialVisibility` to `initialPublicationOnboardingStateChanged` as it was simpler change to do in IB. We can of course change it to something else more appropriate in...

Thanks @nfmohit for reviewing the IB. I have updated the IB as per the suggested points. Re-assigning to you for review. Thanks again!

> ITEM 1: Copy As you can see from the [discussion](https://github.com/google/site-kit-wp/pull/9006#pullrequestreview-2177046961) on previous PR, we just added the component along with the message so that it is convenience to test....

@nfmohit Thank you for reviewing the IB. I've amended the suggested point. Assigning back to you.

As per the conversation in [this slack thread](https://fueled10up.slack.com/archives/C077DB69US2/p1722600439442479), this issue will be on hold in Execution till #8840 is merged so that we can use `SubtleNotification` instead of `SettingsNotice` and...

As discussed previously, I have created a follow-up PR #9177 for this issue which uses `SubtleNotification` component. Also, there are couple of changes in `SubtleNotification` component to allow a notification...

Hi @kelvinballoo , Thank you for reporting this issue. 1. This seems to be a special case. We are trying to compare the data for last 28 days, but as...

@ankitguptaindia Thanks for testing the ticket. I've addressed the points reported by you, please check the below mentioned comments. > Point 1: Continuous Spinner on Account Creation This has been...

Thanks for the feedback @eason9487 I have addressed the changes and responded to other comments. Can you please look over them and let me know in case of any questions?...