Ankit Gade comments

Results 105 comments of


                                            Ankit Gade

Handle the special case for “new visitors” and “returning visitors” to avoid the “partial data” state in the Audience Tile

Thank you @techanvil . I have updated the IB for the points mentioned. Assigning to you for review.

Handle the special case for “new visitors” and “returning visitors” to avoid the “partial data” state in the Audience Tile

Hi @techanvil , Thanks for the heads up regarding revert of #8726 . I've adjusted the IB according to the current state of `AudienceTilesWidget` and `AudienceTile` component. Assigning over to...

Handle the special case for “new visitors” and “returning visitors” to avoid the “partial data” state in the Audience Tile

Thanks @techanvil Once #8923 IB is approved, I will update the IB for this one.

Add the Settings Section setup CTA variant including happy path setup behavior

Thank you so much @kuasha420 for reviewing the IB. I have made some amendments in IB as per your suggestions. Assigning this to you for re-review. Thanks again!

Add the Settings Section setup CTA variant including happy path setup behavior

@kuasha420 Thanks for the spotting the missing point about the success notice. I have addressed the feedback. assigning this to you for re-review. Thanks

Add the Settings Section setup CTA variant including happy path setup behavior

Thank you @kuasha420 . Updated the IB to include new component `AudienceSetupSuccessSettingsNotice` to display success notice and also included mention about the different item key.

Implement the full-tile error states for the Audience Tile

Hi @techanvil , Sorry for missing the QAB update. I've updated the QAB and added the point as note at the top of QAB.

`ConnectAnalyticsCTAWidget` graphics is not loading in IOS browsers

@techanvil I have added the IB in https://github.com/google/site-kit-wp/issues/9983, so please let me know if this can be closed out. Thank you.

Improve publication onboarding state synchronization

Thank you @nfmohit and @techanvil . I have slightly updated the IB so as not to remove `syncPublicationOnboardingState` action and to remove `publicationOnboardingStateLastSyncedAtMs` field. I think rest of it doesn't...

Improve publication onboarding state synchronization

Thank you @techanvil . I've updated the IB to schedule the task only on `load-toplevel_page_googlesitekit-dashboard` and `load-toplevel_page_googlesitekit-settings` actions.