Ankit Gade

Results 105 comments of Ankit Gade

Just a note that for the one who starts execution on this ticket to reference the PR: https://github.com/google/site-kit-wp/pull/8644 as I started working on when it was pulled to execution. This...

Hi @nfmohit Thanks for reviewing the IB. I have a question regarding above comment added in IBR. >Keeping the above in mind, I'd recommend introducing a new `assets/js/components/SetupCTAWidgets.js` component. This...

This is ticket is ready to be moved to CR, but it should be done once #8484 is merged and tested successfully as #8484 is the dependency for this and...

Thanks @techanvil . I will move this to CR as soon as #8484 gets merged. I will also take care to update base branch and merge it to feature one....

Thanks @techanvil for fixing typos and formatting. I have expanded on `SelectionPanelFooter` component props as suggested. I haven't provided too much info on `MetricsFooter` because it would be repetitive. Assigning...

Thank you @techanvil for reviewing the IB. I agree that adding the literal code block is not good idea as the execution should be at the engineer's discretion. As per...

Looking everything good. Thanks @techanvil Moving this to EB.

Hi @techanvil , Thank you for the review. I have addressed your feedback on the PR and also updated QAB so that we create `New visitors` and `Returning visitors` audiences...

Thank you @techanvil for reviewing the PR. I have addressed the comments in the PR and QAB code is looking good. Assigning this back to you for review. Thanks.