Ankit Gade
Ankit Gade
@techanvil This issue can be closed as this has not handled by new Banner component as can be seen [here](https://github.com/google/site-kit-wp/blob/40c7784c282f2da5c8500082649ae4af6e0d5a6c/assets/js/modules/analytics-4/index.js#L734-L740).
@hussain-t As discussed, I will assign this ticket to myself while you look into another one. This ticket was dependent on 2 sub-issue, of which one is approved and other...
Marked this as blocked by #10148 because this issue leads to lot of test failures because of feature flag persistence.
@hussain-t Thank you for looking into this and adding the comment describing the problem. It seems that the problem is happening [here](https://github.com/google/site-kit-wp/blob/ccef7b48f56a58dab8620d0946ecdee20e7072d8/assets/js/modules/analytics-4/index.js#L204-L205) because `availableAudiences` is `undefined` . We already have...
@kelvinballoo > Necessary validation should be implemented for the added module settings. We have got it covered via the test case [here](https://github.com/google/site-kit-wp/blob/develop/assets/js/modules/reader-revenue-manager/datastore/settings.test.js#L54-L84) > Connection logic should be implemented for the...
@kelvinballoo Property positioning in the object does not matter. ``` { "publicationID": "CAow6J6vDA", "publicationOnboardingState": "ONBOARDING_STATE_UNSPECIFIED", "publicationOnboardingStateLastSyncedAtMs": 1721316244959, "ownerID": 1 } ``` OR ``` { "ownerID": 1, "publicationOnboardingStateLastSyncedAtMs": 1721316244959, "publicationOnboardingState": "ONBOARDING_STATE_UNSPECIFIED",...
@asvinb Assigning this to you for CR. There are few fixes for the issues reported by @ankitguptaindia during QA and some adjustments to E2E test cases.
HI @nfmohit , That completely makes sense. In fact I realised this yesterday when I was working on #8837 Thank you for making that change.
I've created the PR: https://github.com/google/site-kit-wp/pull/8950 for this issue, but keeping this issue in Execution because its dependencies #8786 #8791 are yet to be merged. Once merged, the base branch for...
>- After the first script execution, I went ahead to create a publication for the website and triggered the script again. However, this round, there was no request made to...