Ankit Gade

Results 105 comments of Ankit Gade

Adding "Blocked by" #8707 because some logic inside the component `AudienceSegmentationSetupCTAWidget` will get changed in 8707 because of which tests for this issue needs to accommodate the change.

Hi @techanvil , We can discuss about the use of mocks for the actions later when @aaemnnosttv is available. However; I have changed the tests to make use of assertions...

@techanvil Sorry, that was my bad! I committed the changes, but missed to push them. I have pushed the changes and those should be available. Please refer to this [commit](https://github.com/google/site-kit-wp/pull/8741/commits/b5ac326f219ffb16c61331874da94705c0894961)...

@techanvil Thank you. Tests updated as per suggestions.

Thanks @kelvinballoo , As per our [slack conversation](https://10up.slack.com/archives/C077DB69US2/p1718975941739479), we need the analytics property with write access (in order to create audiences in this case). Can you please test it according...

Thank you @hussain-t for reviewing this. I have updated the selector and pushed the changes. Assigning this to you for re-review.

Thank you for reviewing the IB @aaemnnosttv I have revised the IB as per your suggestion to add min width to `googlesitekit-audience-segmentation-tile-metric__container` and the `.googlesitekit-cta-link`, also added the relevant links...

Hi @techanvil , I have added the QAB. As we have already updated the storybook for long title, I have added an additional step (alongside storybook) to modify the other...

Thank you @kelvinballoo for the QA. I have created a new PR https://github.com/google/site-kit-wp/pull/8748 to fix the margin issue. Moving this to CR.

@mohitwp Thanks for looking into this and raising the concern. The issue you flagged is the existing one. This happens when the primary admin sets up the key metrics without...