Andy Waite comments

Results 394 comments of


                                            Andy Waite

Make Rails app detection based on Rails::Application superclass

Hmm, as per @vinistock's comment [here](https://github.com/Shopify/ruby-lsp/issues/2096#issuecomment-2161205953), should we remove the `bin/rails` check and use this instead?

Make Rails app detection based on Rails::Application superclass

Seems there is an issue when the file contains non-ASCII characters: https://github.com/Shopify/ruby-lsp/issues/2463

Support Ruby on Rails detection based on Rails individual gems

I think matching on `class Application < Rails::Application` in `config/application.rb` should be reliable?

Support Ruby on Rails detection based on Rails individual gems

@louim feel free to open a PR for that, should be fairly straightforward.

Fix crawler skipping downloading components

Thanks for looking into this. I tried out your branch and noticed an issue with the `preview` directory:

Update streaming chat tutorial for Rails 8

btw, it works with ActiveJob/SolidQueue with some minor changes, no need for Redis or Sidekiq - I can make a separate PR for that, if you'd like.

Improve performance of finding indexables

I'll set this to draft until @natematykiewicz has chance to return to it.

Add User model prerequisite note to streaming chat tutorial

Reading further I see there's a call to `authenticate_user!` so I've updated this to mention Devise.

Better stack trace upon `Parallel::DeadWorker`

This would have helped for https://github.com/Shopify/tapioca/pull/1826.

100% CPU usage

@tsvallender if you are able to share the LSP logs from just before it causes the CPU to peak, then that may help us to diagnose the problem. Also, are...