Andy Waite
Andy Waite
(it's ugly, but the way RubyMine handles this is with the `RM_INFO` env var: https://www.jetbrains.com/help/ruby/testing-frameworks.html#supported_frameworks )
@thomasmarshall thanks for your work on this, we do still plan to address it but need to prioritize some other things at the moment.
The test helper has `require "ruby_lsp/internal"` which brings in `prism`.
I'm looking into. It can be reproduced consistently with this seed: ``` bundle exec ruby -Itest /Users/andyw8/src/github.com/Shopify/ruby-lsp/test/setup_bundler_test.rb --seed 18973 ```
The minimal set of tests that causes this are: ``` - test_uses_absolute_bundle_path_for_bundle_install - test_creates_custom_bundle_for_a_rails_app ```
If I check `stderr` in `run_script` I see it contains: ``` Minitest::Assertion: Expected "Ruby LSP> Skipping lockfile copies because there's no top level bundle" ``` 🤔
@Earlopain thanks for the pointer. I've pushed a commit on a different branch, and it's passing: https://github.com/Shopify/ruby-lsp/commit/d9a307266f3a43fc527600652233e8f082343940 Will need to discuss with @vinistock if there is a better way to...
Spoke too soon, there might be something else that needs wrapped in `with_isolated_bundler`.
@Earlopain I've taken your suggestion but made a slight change so that we use a file fixture instead of needing to stub the private method (which may be brittle).
Any further thoughts @vinistock @st0012 ?