Andy Waite

Results 397 comments of Andy Waite

Similar to https://github.com/rubocop/rubocop-minitest/pull/221/files

> Also: I noticed that there is activity in Shori repository from the new maintainer. He is reviewing and discussing PRs Thanks for the update. If there's any updates to...

This is important to address, as there is the danger that updating to ESLint v9 can result in checks being silently skipped: https://github.com/Shopify/vscode-shopify-metrics/pull/614

https://github.com/Shopify/web/pull/135110 should help move this forward.

This _should_ be solved by the latest release: https://github.com/Shopify/web-configs/releases/tag/%40shopify%2Feslint-plugin%4046.0.0

Implementation notes (neither are critical for the first iteration): - Should also support `filter`, an alias. - Should support `select!` and `filter!`.

@KaanOzkan @Morriar So as not hold it up any further, I've marked two calls in the latest Core RBI update as `T.unsafe`, with smart TODOs pointing at this issue.

Ah, thank you. If I copy and paste the config it does work. But I would have expected that that if put _only_ this in the config: ``` Layout/ClassStructure: Enabled:...

If we check out the second-newest commit on main, 614084b54bc7b4bbaef8743b5620055d1fa9c3a5, `bundle` runs fine without changing to `Gemfile.lock`. So f529cdcab2a8c4e585ffe1a4e24fe850b260db4c is to blame.

~The problem seems to begin with `rbi` 0.1.8, it's fine with 0.1.7.~