tailwindui-crawler icon indicating copy to clipboard operation
tailwindui-crawler copied to clipboard

Fix crawler skipping downloading components

Open BrandonClapp opened this issue 1 year ago • 3 comments

Fixes #86

There are a couple of issues here

  1. The path is currently derived from the URL, which means that we get incorrect downstream paths like ./output/components/htmlhttps://tailwindui.com/components/application-ui/navigation/navbars when passing this path const.
  2. The downloader is skipping components because it's not parsing the correct segment of the URL. [4] instead of [2] here is what we need to parse the correct segment.

Summary by CodeRabbit

  • New Features

    • Improved accuracy in local path generation based on component URLs.
    • Enhanced component identification from URLs for better filtering.
  • Bug Fixes

    • Corrected the extraction of component names from URLs to align with the intended structure.

BrandonClapp avatar Nov 17 '24 20:11 BrandonClapp

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders
Open Preview

codesandbox[bot] avatar Nov 17 '24 20:11 codesandbox[bot]

Walkthrough

The changes in this pull request primarily focus on the processComponent function and the main execution block of the index.mjs script. Modifications include the adjustment of the path variable to accurately derive the local output path by removing the rootUrl from the url. Additionally, the extraction of the component variable from the URL has been corrected to access the fifth segment instead of the third, ensuring proper parsing of the component name. These adjustments enhance the accuracy of local path generation and component identification.

Changes

File Change Summary
index.mjs Modified processComponent to correctly derive local output path and updated the URL parsing logic to access the fifth segment for component extraction.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Script
    participant URL

    User->>Script: Execute script
    Script->>URL: Retrieve URL
    URL-->>Script: Provide URL
    Script->>Script: Process URL
    Script->>Script: Derive local path
    Script->>Script: Extract component name
    Script-->>User: Output results

🐇 "In the code where paths align,
A rabbit hops with joy divine.
From URLs, we now extract,
The components, clear and intact.
With every change, we leap and bound,
In code's embrace, new paths are found!" 🐇


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar Nov 17 '24 20:11 coderabbitai[bot]

Thanks for looking into this. I tried out your branch and noticed an issue with the preview directory:

Screenshot 2024-12-01 at 1 14 40 PM

andyw8 avatar Dec 01 '24 18:12 andyw8