Andy Waite comments

Results 394 comments of


                                            Andy Waite

Errors when running tests: undefined method `task'

Seems this is due to Rake 0.9.0 being broken: http://stackoverflow.com/questions/5287121/undefined-method-task-using-rake-0-9-0-beta-4

Minitest tests no longer run after requiring 'email_spec'

I'm using minitest-rails and minitest-rails-capybara. I suspect something is conflicting.

Guidance for using html_safe

I haven't done anything with `html_safe` for a while, so I'd need a refresh on the best practices – I'll try come back to this next I'm working on something...

Controller action ordering

Just for the sake of discussion, another possible way of ordering could be to follow CRUD, e.g.: `new create index show edit update destroy`

Controller action ordering

Also, as this [Stack Overflow post](https://stackoverflow.com/a/6421678/119822) says, some people may prefer to group the `new/create` and `edit/update` pairs together.

> Feel free to intermingle them with additional non-resourceful actions deliberately. This feels like it _encourages_ non-resourceful actions, rather than just permitting them. How about: > Use a consistent order...

7 Standard Controller Actions

Another useful education link: http://jeromedalbert.com/how-dhh-organizes-his-rails-controllers/

Use more specific predicates instead of vague `blank?` and `present?`

The only one I really have a strong support for 4. The others can certainly result in clunky code, but I think restricting them may be overly-prescriptive.

Clarify the reasoning for Define Model Class Migrations

For reference, this was originally added in https://github.com/rubocop/rails-style-guide/pull/205 and discussed in #143

Add section for `where.not` with multiple attributes

Personally I would avoid `not` except for trivial cases with a single attribute, but I also wouldn't use a chained `not` as it can still be highly confusing. Instead I...