Andy Waite

Results 394 comments of Andy Waite

We can also update the docs: https://github.com/Shopify/ruby-lsp/pull/3113

Interesting. Seems like bad security risk that you could accidentally mark a string as safe by adding an extra `=`.

> I haven't tried running with JRuby, but I strongly suspect the LSP doesn't run there for similar reasons. JRuby doesn't work because RBS isn't yet supported: https://github.com/Shopify/ruby-lsp/issues/2292

I suspect there are other places with implicit assumptions that we're always running on MRI. We should probably run against TrufleRuby in CI.

Ah, found it: https://github.com/Shopify/ruby-lsp/pull/549 I've restored the branch: `vs/test_against_truffle_and_jruby`

@nevans That's an interesting suggestion, but from my understanding it only runs cops within the `Layout/` category. It would prevent autocorrections by cops from extensions such as `rubocop-rspec` or `rubocop-sorbet`...

Potentially related: https://github.com/Shopify/ruby-lsp-rails/issues/221

The [Spree gem ](https://github.com/spree/spree) may be good to be good example to verify against as it contains multiple engines.

@scheals just a little advice based what you said above: It's almost always worth adding a `Gemfile.lock` to each project you work on. Otherwise you have no guarantee that it...

Note that `stubbing_method_on_nil` is now deprecated: ``` Mocha::Configuration#stubbing_method_on_nil=` is deprecated and will be removed in a future release. `nil` is frozen in Ruby >= v2.2 and Mocha will be dropping...