Andy Waite comments

Results 394 comments of


                                            Andy Waite

Change RDoc docs path

Closing until we determine the wider approach for new docs.

`>` in attribute breaks formatting

Thanks for looking into that! I'm curious though, why didn't you make the changes in a branch and point your Gemfile to that?

`>` in attribute breaks formatting

PR: https://github.com/threedaymonk/htmlbeautifier/pull/82

Send notification to user if rubyLsp.formatter setting isn't in enum

Related: https://github.com/Shopify/ruby-lsp/pull/2092

Send notification to user if rubyLsp.formatter setting isn't in enum

I was thinking that we could still do something similar: If the users selects a formatter that isn't available due to a lack of gem (e.g. `rubyfmt`), we can show...

Send notification to user if rubyLsp.formatter setting isn't in enum

Resolved by https://github.com/Shopify/ruby-lsp/pull/2092

Split `ServerAddon` into new file

Yes, I remember there was a problem, but not the exact details. I agree with the splitting, but for now let's keep `sorbet-runtime` out of the server to reduce the...

Split `ServerAddon` into new file

Hi @johansenja, are you hoping to continue on this?

Allow non-standard values for rubyLsp.formatter option

🤔 A downside of adding other formatters is that it may give the impression they are natively supported, when they actually need an addon.

Allow non-standard values for rubyLsp.formatter option

https://github.com/Shopify/ruby-lsp/pull/2092