Andy Grove

Results 657 comments of Andy Grove

In order to enable the discussions feature, I will need to file an issue with ASF INFRA and will need to provide a link to a "consensus discussion thread". I...

This was completed

I branched from this and created https://github.com/apache/datafusion-comet/pull/505, so closing this one. Thanks @sunchao for getting this started.

Re-opening this since we discovered that there are some correctness and performance issues and currently have this feature disabled by default

There is an existing test `SortMergeJoin with join filter` that we need to enable as part of closing this issue. It was ignored in https://github.com/apache/datafusion-comet/pull/1057

Re-opening this issue because we only enable this feature in tests currently due to poor performance in benchmarks

And I suppose we also need a separate guide on adding cast expressions since there are specific test considerations

This was completed: https://datafusion.apache.org/comet/contributor-guide/adding_a_new_expression.html

I see that multiple people are interested in working on this. I didn't see this until I was mentioned. @sinhs we can't assign issues to people unless they are committers...

Thanks for the contribution @singhpk234. I see this is marked WIP so will hold off on reviewing until it is ready for review. Let us know if you need any...