Andy Grove

Results 664 comments of Andy Grove

> I suppose for this issue it is okay to violate the rule to not modify a field in a protobuf message because we haven't published anything yet. Yes, absolutely.

On the Rust side you will need a `match` statement to convert the protobuf i32 to the Rust enum (0 -> legacy, 1 -> try, 2 -> ansi). Perhaps take...

@prashantksharma also, feel free to create a draft PR as it can be easier for maintainers to make suggestions on the PR

Thanks @comphead. I think it would be good to add a method in DF that lets us get the underlying error string without a prefix.

Should we close this PR @comphead or are you still planning on working on this? I wasn't sure if this is still needed now that some window function support has...

> Also `CommandResult`, which is only used to hold data from a command. `CommandResult` and `Execute CreateViewCommand` are not query execution operators. Thanks. I saw those from the `CREATE VIEW`...

> `BroadcastExchange` should be supported, I think. We have `CometBroadcastExchange`. `BroadcastExchange is not supported` is the information that Comet provides for q8. I think part of this epic will be...

> I will take a look at q8 and see why it is not enabled there. The error `BroadcastExchange is not supported` really means `BroadcastExchange is not supported because the...

@mattharder91 I will close this PR for now since it has been inactive for a while. Feel free to reopen this or create a new PR if you continue work...

> Hello, > > I would like to work on this, if no one has started working on it. Also is there a reference PR to help new comers get...