datafusion-comet icon indicating copy to clipboard operation
datafusion-comet copied to clipboard

Cast string to timestamp remaining work

Open andygrove opened this issue 1 year ago • 5 comments

What is the problem the feature request solves?

https://github.com/apache/datafusion-comet/pull/335 added initial support for casting string to timestamp, but the feature is still disabled by default. There are some follow on items to implement before we can enable by default:

  • Add support for 3 and 5 digit years
  • Testing with try_cast and ANSI
  • Add timezone support (see advice in https://github.com/apache/datafusion-comet/pull/335#issuecomment-2091930125)
  • Passing all fuzz tests
  • Updating compatibility guide

Describe the potential solution

No response

Additional context

No response

andygrove avatar May 03 '24 13:05 andygrove

I'd like to work on this

kiran-4444 avatar May 06 '24 09:05 kiran-4444

I am interested in contributing to this repo. How to assign this issue to myself ?

sinhs avatar May 06 '24 14:05 sinhs

@andygrove I would like to work on this. Can I take it up ?

After seeing that there has been no-activity since a month.

prashantksharma avatar Jun 04 '24 01:06 prashantksharma

@andygrove I would like to work on this. Can I take it up ?

After seeing that there has been no-activity since a month.

@prashantksharma Great! I was about to start working on this, but I'm happy to help if needed.

vaibhawvipul avatar Jun 04 '24 02:06 vaibhawvipul

I see that multiple people are interested in working on this. I didn't see this until I was mentioned.

@sinhs we can't assign issues to people unless they are committers in the repo. We typically just use comments to discuss who is working on an issue, or people just create a PR.

andygrove avatar Jun 04 '24 17:06 andygrove