datafusion-comet icon indicating copy to clipboard operation
datafusion-comet copied to clipboard
verified publisher icon apache

[WIP] Add support for BNLJ

Open singhpk234 opened this issue 1 year ago • 6 comments

Which issue does this PR close?

Closes #.https://github.com/apache/datafusion-comet/issues/198

Rationale for this change

What changes are included in this PR?

Support for BNLJ, this supports is missing in supported joins

How are these changes tested?

UT

singhpk234 avatar Apr 29 '24 04:04 singhpk234

Thanks for the contribution @singhpk234. I see this is marked WIP so will hold off on reviewing until it is ready for review. Let us know if you need any help or have questions.

andygrove avatar May 03 '24 11:05 andygrove

I saw this is in WIP for a while. @singhpk234 Would you like to continue working on it? Or we can have someone take it over? Thanks.

viirya avatar Jun 12 '24 16:06 viirya

Apologies @andygrove @viirya got swamped by internal company work and lost track of this pr, i would able to make it ready for review by EOW for sure (thinking of utilizing this weekend for the same) if it's fine ?

singhpk234 avatar Jun 13 '24 14:06 singhpk234

No worries. Just want to make sure if you still work on it. If not, we could have someone pick it up. Thanks.

viirya avatar Jun 13 '24 15:06 viirya

Thanks @viirya for sure I am on it from now !

singhpk234 avatar Jun 13 '24 15:06 singhpk234

Moving this to draft for now since it has been inactive for a while

andygrove avatar Aug 13 '24 16:08 andygrove

@singhpk234 I will close this PR for now since it has been inactive for a while. Feel free to reopen this or create a new PR if you continue work on this.

andygrove avatar Oct 22 '24 16:10 andygrove